Numlock keybindig support

Report anything that appears to be a bug here.

Moderator: jesse

Post Reply
sejerpz
Posts: 2
Joined: Mon Mar 16, 2009 9:41 am

Numlock keybindig support

Post by sejerpz »

Hi,

I discovered sooperlooper a few days ago and I use it with a self-made usb footswitch done by breaking an usb keyboard and soldering a 1/4" to two lines. Because I was a little bit unlucky I ended up soldering the numlock key lines so when I press the pedal I end up with a numlock key press.

I tried to bind it to the sooperlooper "record-or-overdub" function without any success, so I digged into the sources that by the way are very well written and clear, and here it is a trivial patch that add the support for the numlock key.

Since I'm not able to upload the attachment I paste it here. Feel free to tell me a better place to file bugs ;)

--- sooperlooper-1.6.13/src/gui/keyboard_target.cpp 2005-07-29 05:19:11.000000000 +0200
+++ sooperlooper-1.6.13-my/src/gui/keyboard_target.cpp 2009-03-15 17:28:17.000000000 +0100
@@ -511,6 +511,9 @@
else if (keyname.IsSameAs (wxT("alt"), false)) {
keycode = WXK_ALT;
}
+ else if (keyname.IsSameAs (wxT("numlock"), false)) {
+ keycode = WXK_NUMLOCK;
+ }
else if ( keyname.Len() == 1 ) {
// it's a letter
keycode = keyname[0U];
@@ -660,6 +663,9 @@
case WXK_ESCAPE:
text += wxT("escape");
break;
+ case WXK_NUMLOCK:
+ text += wxT("numlock");
+ break;

default:
if ( wxIsalnum(key) )
jesse
Posts: 554
Joined: Sat Sep 06, 2008 9:46 am
Contact:

Re: Numlock keybindig support

Post by jesse »

Thanks for the patch, and the compliments. Here or the email list are both fine, but for larger patches the email list is probably better, so you can do a proper attachment. Not sure why you couldn't here.
sejerpz
Posts: 2
Joined: Mon Mar 16, 2009 9:41 am

Re: Numlock keybindig support

Post by sejerpz »

Ok, I pasted the patch only beacuse it was very simple ;)

and I cannot attach it here because when I try to upload the file I get this error message:

'The extension txt is not allowed.'

I tried with: .patch, .diff, .txt and without any extension, I think it's just a matter of configuration.

Thanks and bye.
Post Reply